AbstractJasperReportsView doc is out of date [SPR-6390]

[spring-projects-issues]

Johannes Scharf opened SPR-6390 and commented

We use DynamicJasper to render reports with dynamic columns. For that reason I had to write a subclass of AbstractJasperReportsView and overwrite the fillReport method. Inside fillReport I call getReportData to obtain a JRDataSource.

The javadoc of getReportData says:
The default implementation checks for a model object under the specified "reportDataKey" first, then falls back to looking for a value of type JRDataSource, java.util.Collection, object array (in that order).

But the method NEVER looks for the JRDataSource under the "reportDataKey". Instead this lookup is done in the "fillReport" method, which's javadoc seems also to be out of date.

This is very annoying, although not critical. I had to crawl into the code to figure out why getReportData always returned null.

---

Affects: 2.5.5

Referenced from: commits 856fefe

[spring-projects-issues]

Juergen Hoeller commented

Well spotted. Fixed for 3.0 now.

Juergen