Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make private methods protected in DefaultLifecycleProcessor for extension [SPR-6617] #11283

Closed
spring-projects-issues opened this issue Dec 27, 2009 · 1 comment
Closed

make private methods protected in DefaultLifecycleProcessor for extension [SPR-6617] #11283

spring-projects-issues opened this issue Dec 27, 2009 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
3.0.1

Comments

@spring-projects-issues
Copy link
Collaborator

Matt Goldspink opened SPR-6617 and commented

We have a use case where we'd like to be able to stop and start all SmartLifecycle beans that implement a specific interface but in the correct order using JMX. The DefaultLifecycleProcessor could be extended for our use case and we would simply override the getLifecycleBeans() method and return the subset of beans that meet our requirements. It would be great if this method could be made protected to allow for this kind of extension.

Affects: 3.0 GA

Referenced from: commits 431fd5b
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point. getLifecycleBeans and also getPhase are overridable now.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues