Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need detailed log for start and stop Lifecycle beans [SPR-6769] #11435

Closed
spring-projects-issues opened this issue Jan 25, 2010 · 2 comments
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 25, 2010

Liu, Yinwei David opened SPR-6769 and commented

When Spring starts/stops its application context, it uses the class DefaultLifecycleProcessor in Spring 3 to start/stop all Lifecycle beans. However, I think the logging information in DefaultLifecycleProcessor's LifecycleGroup.start() and LifecycleGroup.stop() method is not enough, which does not have some useful information, such as bean name,

Currently, it only has this log info in its class:
if (logger.isWarnEnabled()) {
logger.warn("failed to shutdown beans with phase value " +
this.phase + " within timeout of " + this.timeout);
}

Can we add more detailed debug info here to indicate which bean has been started and which bean has been stopped, and which bean failed?


Affects: 3.0 GA

Issue Links:

Referenced from: commits a897e3f

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've added the names of the missing beans to that log message. I've also added debug logging for each bean as it gets actually started or stopped.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants