Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message error when the MarshallingView modelKey attribute is not valid [SPR-6785] #11451

Closed
spring-projects-issues opened this issue Feb 1, 2010 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Florent Ramiere opened SPR-6785 and commented

When a user specifies an invalid key in the modelKey attribute a NPE exception occurs.
An appropriate error message would help the developer.

 
<bean class="org.springframework.web.servlet.view.xml.MarshallingView">
	<property name="modelKey" value="invalidKey" />
	<property name="marshaller" ref="xstreamMarshaller" />
</bean>

gives

 
java.lang.NullPointerException
        at org.springframework.web.servlet.view.xml.MarshallingView.locateToBeMarshalled(MarshallingView.java:125)
        at org.springframework.web.servlet.view.xml.MarshallingView.renderMergedOutputModel(MarshallingView.java:98)
        at org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:250)
        at org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1060)

Affects: 3.0 GA

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed, thanks for spotting this.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants