Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract URL construction logic out of UrlTag [SPR-6828] #11494

Closed
spring-projects-issues opened this issue Feb 11, 2010 · 3 comments
Closed

Extract URL construction logic out of UrlTag [SPR-6828] #11494

spring-projects-issues opened this issue Feb 11, 2010 · 3 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Kenny MacLeod opened SPR-6828 and commented

I'd like to see the URL-creation logic extracted out of UrlTag into a standalone utility, more suitable for use within controller logic. This utility would essentially contain the logic currently held in urlTag.createUrl(). The tag need only collect the required information, then delegate to this utility.


Affects: 3.0 GA

@spring-projects-issues
Copy link
Collaborator Author

Keith Donald commented

Arjen, sending your way since you have plans for improvements to @Controller Response building in 3.1

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

UrlTag provides capabilities similar to those of the UriTemplate in the form of a JSP tag. Is there anything in the URL-creation logic of UrlTag that UriTemplate does not provide?

@spring-projects-issues
Copy link
Collaborator Author

Kenny MacLeod commented

Actually, UriTemplate effectively resolves this issue. Please close.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 GA milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants