Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak using TransactionDelegate and transaction.commit() [SPR-6991] #11656

Closed
spring-projects-issues opened this issue Mar 15, 2010 · 2 comments
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Christophe Rodriguez opened SPR-6991 and commented

When calling transaction.commit/rollback instead of transactionManager.commit/rollback in the class TransactionDelegate.endTransaction the TransactionManager doesn't unassociate the transaction.

The list of associatedTransactions in org.apache.geronimo.transaction.manager.TransactionManagerImpl keeps de reference of the transaction indefinitely.

Beans:
<jms:jca-listener-container />
org.apache.activemq.ra.ActiveMQResourceAdapter
org.jencks.factory.TransactionManagerFactoryBean


Affects: 2.5.6

Referenced from: commits 4e7752c

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

We weren't aware of that difference between TransactionManager.commit() and Transaction.commit(), and I suppose it may be somewhat specific to Geronimo. Nevertheless, we revised our arrangement there to delegate to TransactionManager.commit/rollback() underneath the Transaction cover.

So as of Spring 3.0.2, this should work fine with Geronimo as well. The change will be available in tonight's 3.0.2 snapshot. Feel free to give it an early try - let us know whether it works for you...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Christophe Rodriguez commented

Tests OK with version 3.0.2.CI-627.
There is no more memory leak.

@spring-projects-issues spring-projects-issues added type: bug A general bug in: data Issues in data modules (jdbc, orm, oxm, tx) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants