Performance improvement for TransactionSynchronizationManager.getSynchronizations() [SPR-6999]

[spring-projects-issues]

Martin Aubele opened SPR-6999 and commented

TransactionSynchronizationManager.getSynchronizations() is a bottleneck in our Liferay Portal:

List is sorted even if empty. During the whole function an array and several lists are created whithout any need.

Please see the attachement for a fix.

Thanks, Martin

---

Affects: 3.0.1

Attachments:

• patch.txt (1.62 kB)

Referenced from: commits 5dc59aa, 19b4618

[spring-projects-issues]

Martin Aubele commented

Patch for TransactionSynchronizationManager

[spring-projects-issues]

Martin Aubele commented

Also the call of thread locals should be minimized. Thats the reason for inlining the (!isSynchronizationActive()) check.

[spring-projects-issues]

Juergen Hoeller commented

I optimized this based on your suggestions for 3.0.2, not only in TransactionSynchronizationManager but also in specific places of AbstractPlatformTransactionManager and WebSphereUowTransactionManager.

The sorting was already optimized a couple of weeks ago, actually, through an OrderComparator.sort(...) call which implicitly only sorts for Lists with >1 elements.

Juergen