Add ability for CNVR to search view names that use file extensions [SPR-7117]

[spring-projects-issues]

David Turanski opened SPR-7117 and commented

A common pattern for supporting multiple document types with a single controller is to append the file extension to the bean name and use BeanNameViewResolver. For example if an application requires both Excel and PDF renderings of the logical view name "view", the corresponding bean names would be "view.xls" and "view.pdf". CNVR currently does not support this pattern since it only tries to resolve "view"

The proposed enhancement uses the mediaTypes map (or JAF in some cases) to obtain the file extension. The request can use path extension, accept header, or request parameter containing the extension. The mediaTypes map is reversed searched to obtain the file extension corresponding to each requested media type (Accept header can specify multiple types). A second pass is made through the view resolvers appending "." + file extension to the view name

A patch is attached

---

Attachments:

• ContentNegotiatingViewResolver.diff (1.40 kB)
• ContentNegotiatingViewResolver.diff (1.29 kB)
• ContentNegotiatingViewResolverTests.diff (5.12 kB)

[spring-projects-issues]

David Turanski commented

I Just noticed a subtle bug in the patch. This is a corner case, but the code that appends the file extension to the view name does not reinitialize the view name properly, so if there are multiple media types requested the second extension would append to the first, etc.

[spring-projects-issues]

David Turanski commented

Updated to fix bug noted in previous comment

[spring-projects-issues]

Arjen Poutsma commented

Done. I've changed the patch a little, to make it clearer (for me) to see what's going on. Let me know what you think.