Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JavaDoc of TaskScheduler interface [SPR-7253] #11912

Closed
spring-projects-issues opened this issue Jun 1, 2010 · 1 comment
Closed

Improve JavaDoc of TaskScheduler interface [SPR-7253] #11912

spring-projects-issues opened this issue Jun 1, 2010 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
3.0.3

Comments

@spring-projects-issues
Copy link
Collaborator

Florian Rampp opened SPR-7253 and commented

Improve the JavaDoc of the TaskScheduler interface by:

  1. specifying the time unit of the long parameters "period" and "delay" in several methods. I suspect its milliseconds, but this should be documented.
  2. specifying what happens, if the "startTime" parameter in several methods is in the past.
  3. improving the comment for TaskRejectedException for all methods. "if the given task was not accepted" is an obvious documentation. What exact conditions lead to this exception?

Affects: 3.0.3

Referenced from: commits 5b420e2
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good points! Fixed for 3.0.3.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues