spring context wrongly created when using aliases [SPR-7254]

[spring-projects-issues]

Tomasz Bech opened SPR-7254 and commented

Under some conditions, spring context is wrongly created.
Problem appears when:

• there are beans/code which requires eager creation of the beans (autowiring by type or getBeansByType());
• there are instances of FactoryBean-s;
• some of the beans during eager creation cannot be instanciated;
• aliases are used;

The original problem happened with cxf library and thousands of objects in spring context. Out of that, hopefully, I was able to build the testcase. It is attached - as separate project (maven).
As it is, it fails with NullPointerException - this means that one of the BeanK has 'wrongly created object of type BeanW' injected.
When you get rid of beanWAlias from the test.xml - test passes.

Look on BeanD - at first time it throws exception during construction - it leads to destorying of eagerly created singletons - but the destruction is not correct/full - beanK remains in the context. It is because 'alias' is used.

---

Affects: 2.5.6

Attachments:

• springTest.zip (9.56 kB)

Referenced from: commits de866a0

[spring-projects-issues]

Tomasz Bech commented

Probably in
DefaultSingletonBeanRegistry.java
public void registerDependentBean(String beanName, String dependentBeanName) {

also aliases should be registered

[spring-projects-issues]

Juergen Hoeller commented

Good catch! Indeed, we need to resolve the specified bean name to the canonical name before we proceed in registerDependentBean.

Fixed for 3.0.3 - will be available in tonight's 3.0.3 snapshot. Feel free to give it an early try...

Juergen

[spring-projects-issues]

Tomasz Bech commented

would it possible to backport patch to 2.5.x tree?
At this stage of our project, I cannot upgrade to Spring 3.x.