Logging performance bottleneck in DispatcherServlet / UrlPathHelper [SPR-7269] #11928
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Milestone
Kenny MacLeod opened SPR-7269 and commented
DispatcherServlet.getLastModified
constructs a newUrlPathHelper
object each time it is called, which in turn callsLogFactory.getLog
. Considering thatDispatcherServlet.getLastModified
is on the critical execution path, this adds up to a small but significant performance bottleneck.From what I can see of
UrlPathHelper
, it should be threadsafe, and theDispatcherServlet
should be able to keep a single instance as an object field, rather than instantiating a new one each time.Affects: 3.0.2
Referenced from: commits eb3a3a6
The text was updated successfully, but these errors were encountered: