Synchronization in AnnotationMethodHandlerAdapter [SPR-7525]

[spring-projects-issues]

Jozef Hovan opened SPR-7525 and commented

After upgrade from Spring framework 3.0.3 to 3.0.4 our web application started to throw IndexOutOfBoundsExceptions.

SEVERE: Servlet.service() for servlet ebroker threw exception
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.RangeCheck(ArrayList.java:547)
at java.util.ArrayList.get(ArrayList.java:322)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$RequestMappingInfo.bestMatchedPattern(AnnotationMethodHandlerAdapter.java:1017)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$ServletHandlerMethodResolver.resolveHandlerMethod(AnnotationMethodHandlerAdapter.java:613)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:422)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:415)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:788)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:717)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:560)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

---

Affects: 3.0.4

Issue Links:

• PathVariable mappings are greedy over hard coded mappings [SPR-5367] #10040 PathVariable mappings are greedy over hard coded mappings

Referenced from: commits e035477

[spring-projects-issues]

Juergen Hoeller commented

Indeed, due to a change in ServletHandlerMethodResolver's internal caching, we have to perform extended caching when creating those resolver instances. Fixed for 3.0.5, for the Servlet as well as for the Portlet case.

This will be available in tonight's 3.0.5 snapshot. Feel free to give it a try and check whether you cannot reproduce the issue anymore...

Juergen

[spring-projects-issues]

dave sinclair commented

Hi Juergen,

I got the snapshot and still saw this problem. Same stack trace

java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.RangeCheck(ArrayList.java:547)
at java.util.ArrayList.get(ArrayList.java:322)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$RequestMappingInfo.bestMatchedPattern(AnnotationMethodHandlerAdapter.java:1018)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$ServletHandlerMethodResolver.resolveHandlerMethod(AnnotationMethodHandlerAdapter.java:614)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:421)
at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:414)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:790)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:719)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:560)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

[spring-projects-issues]

Juergen Hoeller commented

As part of #10040, we did actually revisit that code once more just earlier today, exactly with respect to bestMatchedPattern storage. As a consequence, I expect this to really be fixed now - in the next 3.0.5 snapshot, coming up in a few hours. Please give it a try...

Juergen

[spring-projects-issues]

dave sinclair commented

That did it! Thanks Juergen

dave

[spring-projects-issues]

Jozef Hovan commented

It seems ok in version 3.0.5. Thanks.