Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'default-merge' attribute value does not propagate to collection elements [SPR-7656] #12312

Closed
spring-projects-issues opened this issue Oct 14, 2010 · 0 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Chris Beams opened SPR-7656 and commented

collection elements in the beans schema (<list>, <set>, <map>, <props>, <array>) each expose a 'merge' attribute of type 'defaultable-boolean'. All such attributes should also explicitly set default="default", but these elements do not.

This violates expectations during parsing, as the parsing routine expects the default value to be the literal string "default", in which case the parent <beans> element's default values are interrogated as a fallback. Instead, these attributes default to empty string. Thus, if <beans default-merge="true"/> has been set, it never gets propagated to the individual collection elements, because the parsing routine didn't think it was necessary.

This appears to have been the case since as early as Spring 2.0. Apparently there aren't many folks using default-merge!


Affects: 2.0 final

Referenced from: commits c7aaa85

@spring-projects-issues spring-projects-issues added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.5 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant