Path variable in class-level @RequestMapping not working properly [SPR-8858]

[spring-projects-issues]

Bozhidar Bozhanov opened SPR-8858 and commented

@RequestMapping("/{foo}")
public class FooController {
   @RequestMapping("/bar")
   public String bar(@PathVariable String foo) {
   }
}

That is not parsed properly - the path spring maps it to is simply "/bar". To make it work, you have a number of options:

• /{foo}/ (add a slash)
• /{foo}/baz (add anything after that)
• /bar/ (add a trailing slash)

That way it works, but it's not what we want - we want /foo/bar, not /foo//bar, and not /foo/bar/

---

Affects: 3.1 RC1

Issue Links:

• Wrong path mapping combination between type-level and method-level @RequestMapping on @Controller [SPR-7970] #12625 Wrong path mapping combination between type-level and method-level @RequestMapping on @Controller

Referenced from: commits b5bcfa0

[spring-projects-issues]

Rossen Stoyanchev commented

It looks like an unintended consequence of this use case supported in AntPathMatcher's combine() method:

assertEquals("/hotel", pathMatcher.combine("/*", "/hotel"));
assertEquals("/*.html", pathMatcher.combine("/*.*", "/*.html"));

We'll investigate a solution. In the mean time you can try using this:

@RequestMapping("/{foo}/")
public class FooController {
   @RequestMapping("bar")
   public String bar(@PathVariable String foo) {
   }
}

[spring-projects-issues]

Rossen Stoyanchev commented

The combine method of AntPathMatcher now checks if the first pattern contains URI template variable syntax and if so prevents the described behavior from occurring.