AspectJ @Transactional aspect uses runtime checks [SPR-8890]

[spring-projects-issues]

Dale Peakall opened SPR-8890 and commented

The AspectJ support for the @Transactional annotation uses pointcuts that include "runtime" conditions. These conditions mean that every method on every object processed by AspectJ will be weaved with code that checks for the presence of the annotation at runtime. This is hugely inefficient. The pointcuts can be rewritten so AspectJ only weaves code into the classes that have actually been annotated.

private pointcut executionOfAnyPublicMethodInAtTransactionalType() :
  execution(public * ((@Transactional *)+).*(..)) && @this(Transactional);

private pointcut executionOfTransactionalMethod() :
  execution(* *(..)) && @annotation(Transactional);

private pointcut executionOfAnyPublicMethodInAtTransactionalType() :
  execution(public * ((@Transactional *)+).*(..)) && within(Transactional);

private pointcut executionOfTransactionalMethod() :
  execution(@Transactional * *(..));

---

Affects: 3.1 RC2

Referenced from: commits f74789f, 5ab2bf1, 3a62aa0, a347e4d

[spring-projects-issues]

Dale Peakall commented

The Fixed version for the first pointcut should be ... && within(@Transactional)

[spring-projects-issues]

Dale Peakall commented

Even simpler: execution(* *(..)) && within(@Validate *);