Spring @Async should have some way of specifying UncaughtExceptionHandler [SPR-8995]

[spring-projects-issues]

Dwayne D'Souza opened SPR-8995 and commented

Currently an exceptions in Async proxied methods fail silently and do not pass to the default UncaughtExceptionHandler. This means you need to wrap every async method with AspectJ in order to achieve unexpected error handling in these methods.

e.g.

@Override
@Async
public void asyncExceptionTest() {
int i=1/0;
}

This will fail silently.

---

Issue Links:

• UncaughtExceptionHandler is not configured with AspectJ [SPR-12090] #16706 UncaughtExceptionHandler is not configured with AspectJ
• Asynchronous method execution is always invoked before bean validation [SPR-11775] #16397 Asynchronous method execution is always invoked before bean validation
• Use ErrorHandler in TaskExecutors [SPR-8603] #13246 Use ErrorHandler in TaskExecutors

19 votes, 20 watchers

[spring-projects-issues]

Gareth Smith commented

Somebody has posted a workaround here: http://stackoverflow.com/questions/8735870/spring-async-uncaught-exception-handler

[spring-projects-issues]

Stéphane Nicoll commented

The reason why the UncaughtExceptionHandler is not invoked is because the ExecutorService does not honour that. Specifically, we use ThreadPoolExecutor that has a callback method for that kind of use case: [afterExecute](http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#afterExecute(java.lang.Runnable, java.lang.Throwable))

See also this thread

We intend to provide a dedicated callback handler for asynchronous operations that would provide more context.

[spring-projects-issues]

Stéphane Nicoll commented

The current plain is to define a new interface AsyncUncaughtExceptionHandler that can be specified on either task:annotation-driven or AsyncConfigurer.

When an exception is thrown from an asynchronous method invocation and that method has a void return type, the AsyncUncaughtExceptionHandler is invoked with the exception, the method and the method arguments.

[spring-projects-issues]

Janning Vygen commented

The solution only works for Proxy but not AspectJ mode in 4.1.0.RC2
See AspectJAsyncConfiguration vs ProxyAsyncConfiguration

[spring-projects-issues]

Stéphane Nicoll commented

Thanks, I have created #16706

[spring-projects-issues]

Mukund Jalan commented

Update may be needed as per #18954

[spring-projects-issues]

Stéphane Nicoll commented

This issue is closed. What update are you talking about?