Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests related to java.beans.BeanInfo changes in JDK8-b117 [SPR-11139] #15765

Closed
spring-projects-issues opened this issue Dec 2, 2013 · 3 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Brian Clozel opened SPR-11139 and commented

Starting JDK8-b117, several tests fail in spring-beans.

org.springframework.beans.ExtendedBeanInfoTests > indexedReadMethodReturnsSupertypeOfIndexedWriteMethodParameter FAILED
    java.beans.IntrospectionException at ExtendedBeanInfoTests.java:340

org.springframework.beans.ExtendedBeanInfoTests > readMethodReturnsSupertypeOfWriteMethodParameter FAILED
    java.beans.IntrospectionException at ExtendedBeanInfoTests.java:323

Because of changes/fixes in the java.beans introspection codebase, some edge cases of java.beans.BeanInfo are now fixed.


Affects: 4.0 RC2

Backported to: 3.2.6

0 votes, 5 watchers

@spring-projects-issues
Copy link
Collaborator Author

Brian Clozel commented

JDK8-b118 is out, see changelog.
Same results with those tests.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Sorting this out against JDK8-b119 now...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Turns out that there were issues in ExtendedBeanInfo itself as well as in ExtendedBeanInfoTests.

I've rephrased those two tests to expect equivalence between standard BeanInfo and ExtendedBeanInfo there, so if they're running on a recent JDK build, the tests are going to insist on the write methods being discovered in both cases now.

As for ExtendedBeanInfo itself, I've relaxed the checks between read and write methods a bit, accepting superclass/subclass relationships in both directions there.

I intend to backport these changes to 3.2.6 as well, so that the behavior with 3.2.6 running on JDK 8 is equivalent.

Juergen

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0 GA milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants