Make MockRestServiceServer error messages more descriptive [SPR-12230]

[spring-projects-issues]

Elnur Abdurrakhimov opened SPR-12230 and commented

Currently, when making an unexpected request to the mock server, I get an exception java.lang.AssertionError: No further requests expected.

It's a real pain to find out which request is at fault, because there is not enough information in that exception's stacktrace.

It would be really helpful to have all the expected requests, that were already done, to be displayed. It should also display which request was expected next and which one came instead and caused the expectations to fail.

---

Affects: 3.2 GA

Issue Links:

• MockRestServiceServer should allow more verification options [SPR-12408] #17016 MockRestServiceServer should allow more verification options

Backported to: 4.0.8, 3.2.12

[spring-projects-issues]

Rossen Stoyanchev commented

This exception is an indication that all expected requests were created. In other words there is no next request expected. We could of course print all executed requests so far but that's identical to the requests set up as expectations in the test.

[spring-projects-issues]

daniel carter commented

I guess the key part is "which one came in instead". i.e. what was the request that was not expected.

[spring-projects-issues]

Rossen Stoyanchev commented

Right, that one we should log. I imagine the stack is probably good enough in many cases unless requests are created in a loop?