org.springframework.context.support.LiveBeansView.generateJson(Set<ConfigurableApplicationContext>) generates invalid JSON when resources already double-quoted [SPR-12252]

[spring-projects-issues]

Aldo Luciano opened SPR-12252 and commented

result.append(""resource": "").append(resource).append("",\n") in org.springframework.context.support.LiveBeansView.generateJson(Set<ConfigurableApplicationContext>) creates invalid JSON if resource already has quotes.

Found this issue while invoking actuator's /beans endpoint:

...
{
"bean": "securityConfig",
"scope": "singleton",
"type": "demo.SecurityConfig$$EnhancerBySpringCGLIB$$79f7591d",
"resource": ""/C:/Users/904311/Documents/workspace-sts-3.6.1.RELEASE/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_AS_6.x1410896169876/deploy/jboss-demo.war/WEB-INF/classes/demo/SecurityConfig.class"",
...

...then com.fasterxml.jackson.core.json.ReaderBasedJsonParser._skipComment() throws an exception.

---

Affects: 3.2.11, 4.0.7

Backported to: 4.0.8, 3.2.12

[spring-projects-issues]

Juergen Hoeller commented

This will be available in the upcoming 4.1.1 snapshot. Please give it a try...

It'll get backported to 4.0.8 and 3.2.12 tonight.

Juergen

[spring-projects-issues]

Phil Webb commented

I've just pushed a fix to master to protect against an NPE which the Boot tests triggered. You probably want to include 3827e04 in the backports.

[spring-projects-issues]

Juergen Hoeller commented

Alright - just in time...

Juergen