JavaDoc of AnnotatedTypeMetadata.getAllAnnotationAttributes is misleading. [SPR-12473]

[spring-projects-issues]

Christoph Strobl opened SPR-12473 and commented

Given the following structure one would assume that getAllAnnotationAttributes gets all values for someType which would be Object.class and String.class but only the attributes of the meta annotation get evaluated which is different to what getAnnotationAttributes does.

public class StandardAnnotationMetadataUnitTests {

	@Test
	@SuppressWarnings("rawtypes")
	public void standardAnnotationMetadataGetAllAnnotationAttributesShouldContainAttributesReturnedByGetAnnotationAttributes() {

		StandardAnnotationMetadata metadata = new StandardAnnotationMetadata(Config.class);
		assertThat((Class) metadata.getAnnotationAttributes(MetaAnnotation.class.getName()).get("someType"),
				Is.<Class> is(String.class));
		assertThat((List<Object>) metadata.getAllAnnotationAttributes(MetaAnnotation.class.getName())
				.get("someType"), IsIterableContainingInAnyOrder.<Object> containsInAnyOrder(String.class, Object.class));
	}

	@ConcreteAnnotation
	static class Config {

	}

	@Target({ ElementType.TYPE, ElementType.ANNOTATION_TYPE })
	@Retention(RetentionPolicy.RUNTIME)
	@Documented
	@Inherited
	public static @interface MetaAnnotation {

		Class<?> someType() default Object.class;
	}

	@Target({ ElementType.TYPE })
	@Retention(RetentionPolicy.RUNTIME)
	@Documented
	@Inherited
	@MetaAnnotation
	public static @interface ConcreteAnnotation {

		Class<?> someType() default String.class;
	}

}

---

Affects: 4.0.8, 4.1.2

Referenced from: commits 5ac8680, f44217a

Backported to: 4.0.9