Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update Javadoc on RestTemplate/AsyncRestTemplate to highlight supported HTTP client libraries [SPR-13313] #17898

Closed
spring-projects-issues opened this issue Aug 4, 2015 · 4 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Stojan Sljivic opened SPR-13313 and commented

Is there any plan to support non blocking IO, Java NIO2, in AsyncRestTemplate?

Thanks


Referenced from: commits bdf7351

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

AsyncRestTemplate can be used with Apache HttpComponents and Netty clients both of which are non-blocking. Can you elaborate?

@spring-projects-issues
Copy link
Collaborator Author

Stojan Sljivic commented

Is there any example how AsyncRestTemplate can be used with Apache HttpComponents and Netty clients?

@spring-projects-issues
Copy link
Collaborator Author

Stojan Sljivic commented

OK, I just realized that there are several implementations of AsyncClientHttpRequestFactory (HttpComponentsAsyncClientHttpRequestFactory, Netty4ClientHttpRequestFactory, etc.).

It would be good to have at least some kind of javadoc in the AsyncRestTemplate that would point out to those implementations and provide some sample configurations. This way users are left to figure out everything from the code it self. I could be wrong, but I could not find any documentation about this.

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Fair enough. The type-level Javadoc should be more explicit about the range of underlying HTTP clients supported. It's an important thing to know up-front.

@spring-projects-issues spring-projects-issues added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants