Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionResourceResolver should add ETag headers when resolving resources [SPR-13382] #17963

Closed
spring-projects-issues opened this issue Aug 23, 2015 · 3 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 23, 2015

Brian Clozel opened SPR-13382 and commented

VersionStrategy and VersionResourceResolver can resolve resources using version strings.
Those resources are then served without using this version information to set the ETag header.

The VersionResourceResolver should by default add this header value as this is valuable for HTTP clients. It should also provide an optional configuration setting to disable that behavior.


Affects: 4.2 GA

Issue Links:

Referenced from: commits 190eb6a

@spring-projects-issues
Copy link
Collaborator Author

Brian Clozel commented

As of this commit, the ETag header is automatically added in HTTP responses when a VersionResourceResolver is used.

@spring-projects-issues
Copy link
Collaborator Author

Christian Köberl commented

It seems that this just works on the first request - because the second (and further) request are usually handled via the CachingResourceResolver.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Dec 23, 2015

Brian Clozel commented

Thanks Christian Köberl, I've created #18390!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants