Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultDeserializer should use ConfigurableObjectInputStream [SPR-13409] #17988

Closed
spring-projects-issues opened this issue Aug 30, 2015 · 1 comment
Closed

DefaultDeserializer should use ConfigurableObjectInputStream [SPR-13409] #17988

spring-projects-issues opened this issue Aug 30, 2015 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
4.2.1

Comments

@spring-projects-issues
Copy link
Collaborator

Rob Winch opened SPR-13409 and commented

It would be nice if DefaultDeserializer would use ConfigurableObjectInputStream with the ClassUtils.getDefaultClassLoader(). This would prevent issues with things like spring-boot/issues/3805

Affects: 4.2 GA

Reference URL: spring-projects/spring-boot#3805

Issue Links:

  • DATAREDIS-427 Allow injecting deserializer for JdkSerializationRedisSerializer

Referenced from: commits d99717c
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've revised DefaultDeserializer and DeserializingConverter to accept a given ClassLoader through an overloaded constructor.

ObjectInputStream itself actually uses the "latest user-defined ClassLoader", so I'm not keen on a hard override there. Allowing for an explicitly given ClassLoader seems to be the best compromise here.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
4.2.1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues