Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation is missing for sendTimeLimit bufferSizeLimit for ConcurrentWebSocketSessionDecorator [SPR-13753] #18326

Closed
spring-projects-issues opened this issue Dec 2, 2015 · 1 comment
Closed

Documentation is missing for sendTimeLimit bufferSizeLimit for ConcurrentWebSocketSessionDecorator [SPR-13753] #18326

spring-projects-issues opened this issue Dec 2, 2015 · 1 comment
Assignees
@jhoeller
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone
4.2.4

Comments

@spring-projects-issues
Copy link
Collaborator

Devender Singh Garha opened SPR-13753 and commented

Documentation is missing for the significance of below two fields in the constructor of ConcurrentWebSocketSessionDecorator also metric for int sendTimeLimit, int bufferSizeLimit -will it be sec/kb, min/mb.

Affects: 4.1.5

Referenced from: commits b3eefa2, 747863d

Backported to: 4.1.9
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

It's milliseconds and number of bytes, respectively. I've added this to all applicable places, e.g. also in SubProtocolWebSocketHandler.

Juergen

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: documentation A documentation task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.4 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Milestone
4.2.4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues