ControllerAdviceBean javadoc is inconsistent with its implementation [SPR-13759]

[spring-projects-issues]

Andy Wilkinson opened SPR-13759 and commented

The javadoc states that:

The findAnnotatedBeans(ApplicationContext) method can be used to discover such beans. However, a ControllerAdviceBean may be created from any object, including ones without an @ControllerAdvice.

However, the implementation says otherwise:

ControllerAdvice annotation = AnnotationUtils.findAnnotation(beanType, ControllerAdvice.class);
if (annotation == null) {
     throw new IllegalArgumentException(
                   "Bean type [" + beanType.getName() + "] is not annotated as @ControllerAdvice");
}

---

Affects: 4.1.8, 4.2.3

Referenced from: commits d64ac32, 6963e27

Backported to: 4.1.9

[spring-projects-issues]

Juergen Hoeller commented

Andy Wilkinson, have you had a specific issue where you ran into this? Does the fix look alright, i.e. does a recent 4.2.4.BUILD-SNAPSHOT work for you there?

Juergen

[spring-projects-issues]

Andy Wilkinson commented

Not personally, no. I was helping a Boot user who was looking for a way to use @ControllerAdvice without relying on component scanning which led to me noticing the inconsistency. Unfortunately, that means I don't have any code that I can try against the change. FWIW, on visual inspection, the change looks good to me.