Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Common Annotations 1.1's javax.annotation.Resource.lookup() [SPR-13941] #18513

Closed
spring-projects-issues opened this issue Feb 12, 2016 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

The Alchemist opened SPR-13941 and commented

It looks like Resource.lookup() is ignored. Since lookup() is a "standard" location and mappedName() is platform-specific, perhaps support for lookup() would be preferable.


Referenced from: commits b79e8a5

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

The lookup() attribute was introduced as part of the Commons Annotations 1.1 revision in 2009, along with Java EE 6. It is not present in the JDK 6 version of the annotation that our support has been designed against back in 2007.

We'll try to support it with meaningful semantics as of Spring Framework 4.3. Thanks for raising this!

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

It seems that the cleanest semantics are essentially the same that we use for mappedName(): a straight JNDI lookup with the specified location. We'll have to reflectively check that attribute (since it is not present in Java 6 / Java EE 5 which we still support at runtime) but can otherwise treat it just like we treat mappedName() already.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants