Allow @ContextConfiguration to be omitted [SPR-13955]

[spring-projects-issues]

Phil Webb opened SPR-13955 and commented

The @ContextConfiguration annotation is often not really needed if working with a single config. For example:

@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration 
public class MyTest {

	@Test
	public void sometest() throws Exception {

	}

	@Configuration
	static class Config {

		@Bean
		public String myBean() {
			return "Hello";
		}

	}

}

---

Issue Links:

• Allow AbstractTestContextBootstrapper to provide default ContextConfigurationAttributes [SPR-13949] #18521 Allow AbstractTestContextBootstrapper to provide default ContextConfigurationAttributes
• Allow AbstractTestContextBootstrapper to provide default ContextConfigurationAttributes [SPR-13949] #18521 Allow AbstractTestContextBootstrapper to provide default ContextConfigurationAttributes ("supersedes")

Referenced from: commits 2244461

[spring-projects-issues]

Sam Brannen commented

Is this intended to supersede #18521, or is it in addition to #18521?

[spring-projects-issues]

Phil Webb commented

It would be in addition to I think. I'm still working though some ideas and I just wanted to jot it down.

[spring-projects-issues]

Phil Webb commented

Combined PR available for review at #983

[spring-projects-issues]

Sam Brannen commented

Phil Webb,

I'm still wondering about this...

Is this intended to supersede #18521, or is it in addition to #18521?

[spring-projects-issues]

Phil Webb commented

It's very subtle but I think they are different requests. See 636baf9b and d74f9e66 for the respective commits.

Having said that, I think my original use-case for #18521 has gone and I don't appear to be overriding the protected getDefaultContextConfigurationAttributes method in my current prototype. Originally I had used that to allow detection of the @Configuration class, I do do that by overriding processMergedContextConfiguration.

[spring-projects-issues]

Sam Brannen commented

Pushed to master with several changes:

2244461

[spring-projects-issues]

Sam Brannen commented

Thanks for the explanation, Phil.

Since you're no longer using that feature, I'll close #18521 for now.

Cheers!