Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide flag to allow ServletTestExecutionListener to run without @WebAppConfiguration [SPR-14035] #18607

Closed
spring-projects-issues opened this issue Mar 10, 2016 · 3 comments
Closed

Provide flag to allow ServletTestExecutionListener to run without @WebAppConfiguration [SPR-14035] #18607

spring-projects-issues opened this issue Mar 10, 2016 · 3 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
4.3 RC1

Comments

@spring-projects-issues
Copy link
Collaborator

Phil Webb opened SPR-14035 and commented

Currently ServletTestExecutionListener only kicks in when @WebAppConfiguration is on the testClass. Spring Boot would like to use the listener from test configured via a Bootstrapper and which don't contain @WebAppConfiguration annotations.

Can we consider adding additional attribute based activation?

Affects: 4.2.5

Referenced from: commits 8222ff4, bb590db
@spring-projects-issues
Copy link
Collaborator Author

Phil Webb commented

#996

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Yes, this sounds reasonable. Thanks for the PR. I'll look into it.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Merged into master in the following commit:

8222ff4

@spring-projects-issues spring-projects-issues added in: test Issues in the test module type: enhancement A general enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
4.3 RC1
Development

No branches or pull requests
2 participants
@sbrannen @spring-projects-issues