Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTag's "modelAttribute" should consistently supersede "commandName" [SPR-14094] #18666

Closed
spring-projects-issues opened this issue Mar 29, 2016 · 1 comment
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Tomoyuki Ikeya opened SPR-14094 and commented

In my understanding, commandName of FormTag is legacy attribute. Most modern applications may use modelAttribute instead of it.
Now I could not see any description of modelAttribute at the reference. It's better to replace or add descriptions for modelAttribute at the reference to avoid confusion.


Affects: 4.2.5

Reference URL: http://docs.spring.io/spring/docs/4.2.5.RELEASE/spring-framework-reference/htmlsingle/#view-simple-binding

Referenced from: commits 2dae4d8

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've taken the opportunity to officially deprecate setCommandName/getCommandName on the FormTag class, removing all references to it from the documentation.

@spring-projects-issues spring-projects-issues added type: documentation A documentation task in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants