Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AntPathMatcher regression in 4.3 RC1 [SPR-14141] #18713

Closed
spring-issuemaster opened this issue Apr 9, 2016 · 0 comments
Closed

AntPathMatcher regression in 4.3 RC1 [SPR-14141] #18713

spring-issuemaster opened this issue Apr 9, 2016 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 9, 2016

Stephan Schroevers opened SPR-14141 and commented

The following test passes with version 4.2.5.RELEASE but fails with 4.3.0.RC1:

@Test
public void testPathMatcher() {
	PathMatcher matcher = new AntPathMatcher();
	assertTrue(matcher.match("https://example.com", "https://example.com"));
}

Cursory debugging indicates that the double slashes are problematic. The following test passes with both versions:

@Test
public void testPathMatcher() {
	PathMatcher matcher = new AntPathMatcher();
	assertTrue(matcher.match("https:/**/example.com", "https://example.com"));
}

This regression seems relevant because double slashes are common in patterns provided to the following methods:

  • MockMvcResultMatchers#forwardedUrlPattern
  • MockMvcResultMatchers#redirectedUrlPattern

I suspect this is related to #18487.


Affects: 4.3 RC1

Issue Links:

  • #18487 Speed up AntPathMatcher by doing prefix-match

Referenced from: commits 368f29d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.