Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart range requests leave file handles open [SPR-15559] #20118

Closed
spring-projects-issues opened this issue May 16, 2017 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Aaron Sharp opened SPR-15559 and commented

If a browser sends a multipart range request (with the header Range: bytes=1-2,3-4), the ResourceRegionHttpMessageConverter executes its method writeResourceRegionCollection(Collection, HttpOutputMessage). This method opens input streams to each ResourceRegion that the request specifies, but never closes them. These file handles are left open, and if too many accumulate, the web server can crash.

So far, I have only seen multipart range requests when Internet Explorer (version 11) is interrupted during a long download, and the user clicks refresh to complete the download.


Affects: 4.3.7, 4.3.8

Referenced from: commits eaac348, 22bf9fe

@spring-projects-issues spring-projects-issues added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.9 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants