Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RegexPatternTypeFilter include filter for component index [SPR-16010] #20559

Closed
spring-projects-issues opened this issue Sep 26, 2017 · 1 comment
Closed

Support RegexPatternTypeFilter include filter for component index [SPR-16010] #20559

spring-projects-issues opened this issue Sep 26, 2017 · 1 comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression)

Comments

@spring-projects-issues
Copy link
Collaborator

Mark Paluch opened SPR-16010 and commented

Using ClassPathScanningCandidateComponentProvider with an RegexPatternTypeFilter include filter prevents use of the component index.

It might be worth to evaluate regex on the component index so Spring Data's custom repository implementation scan could benefit from component-index-based scanning. RegexPatternTypeFilter is used on every scan to limit component candidates with a simple class name.

It also might be worth introducing a SimpleClassNameTypeFilter dedicated to this style of filtering to eliminate regex pattern compilation and the associated matching cost.

No further details from SPR-16010
@spring-projects-issues spring-projects-issues added status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) and removed type: enhancement A general enhancement labels Jan 11, 2019
@snicoll
Copy link
Member

snicoll commented Sep 18, 2023

The context indexer has been deprecated and we don't intent to make further changes to it.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @spring-projects-issues