Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UriTemplate.matches boolean has greedy behavior at the end of a pattern [SPR-16169] #20717

Closed
spring-projects-issues opened this issue Nov 7, 2017 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

R. Michael Rogers opened SPR-16169 and commented

The following test fails:

@Test
public void uriTemplatesShouldHaveSaneMatching() {
    UriTemplate template = new UriTemplate("/account/{accountId}");
    assertThat(template.matches("/account/15/alias/5"), is(equalTo(false)));
}

My expectation is that UriTemplate.matches should have the same behavior as the @RequestMapping annotation and I haven't been able to find any documentation that contradicts (nor reinforces) that understanding.


Affects: 4.3.6

Referenced from: commits c60313d

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants