Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.2 [SPR-16239] #20786

Closed
spring-issuemaster opened this issue Nov 29, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Nov 29, 2017

Sébastien Deleuze opened SPR-16239 and commented

Kotlin 1.2 has been released and provides useful syntax enhancements, faster compilation and multiplatform support. That's the version we are likely going to use for Spring Boot 2 and start.spring.io as well, so let's upgrade to it, potentially using -api-version 1.1 and -language-version 1.1 to keep good compatibility with those who stick to 1.1.


Reference URL: http://kotlinlang.org/docs/reference/compatibility.html

Issue Links:

  • #20742 Upgrade to Kotlin 1.1.61
  • #20945 Upgrade to Kotlin 1.3

Referenced from: commits 821ab62, 7368f58

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 29, 2017

Sébastien Deleuze commented

I have asked Kotlin compiler team confirmation that it is safe for Spring Framework to build binaries with Kotlin 1.2 with apiVersion = 1.1 and languageVersion = 1.1 option enabled while keeping compatibility with Kotlin 1.1 projects. The compatibility documentation mentions "OV compiler may not accept NV binaries (e.g. those that exhibit newer language features or APIs)".

If their answer is yes, I plan to merge this commit.

If their answer is no, I think staying on Kotlin 1.1 in Spring Framework 5.0 and leveraging Kotlin 1.2 as of Spring Boot 2.0.RC1 and start.spring.io will be our best option, upgrading to Kotlin 1.2 in Spring Framework 5.1 timeframe.

In both case, I do think Spring Boot 2 and start.spring.io should leverages Kotlin 1.2.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 30, 2017

Sébastien Deleuze commented

I got confirmation from Dmitry Jemerov that it is safe to switch to Kotlin 1.2 with the 2 flags set to 1.1 in order to keep compatibility with Kotlin 1.1 projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.