Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation refers to org.projectreactor:reactor-net which seem not to exist on projectreactor Bismuth [SPR-16802] #21342

Closed
spring-projects-issues opened this issue May 9, 2018 · 2 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Ilpo Kettunen opened SPR-16802 and commented

Documentation for STOMP External broker configuration mention org.projectreactor:reactor-net as needed dependency. But current Springframework depend on projectreactor Bismuth-SR9 which do not have that package anymore.

See: https://docs.spring.io/spring/docs/5.0.6.RELEASE/spring-framework-reference/web.html#websocket-stomp-handle-broker-relay


Affects: 5.0.6

Referenced from: commits 82a8e42, 9179a4f

@spring-projects-issues
Copy link
Collaborator Author

Ilpo Kettunen commented

Is there typo on this fix?

Shouldn't it be io.projectreactor.*ipc*:reactor-netty instead of io.projectreactor.*netty*:reactor-netty

 

82a8e42

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

The groupId is changing to io.projectreactor.reactor in 0.8, so this is in anticipation of that.

@spring-projects-issues spring-projects-issues added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.7 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants