Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MethodBeforeAdviceInterceptor should implement BeforeAdvice marker [SPR-17088] #21625

Closed
spring-projects-issues opened this issue Jul 25, 2018 · 1 comment
Closed

MethodBeforeAdviceInterceptor should implement BeforeAdvice marker [SPR-17088] #21625

spring-projects-issues opened this issue Jul 25, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: task A general task
Milestone
5.0.8

Comments

@spring-projects-issues
Copy link
Collaborator

Juergen Hoeller opened SPR-17088 and commented

Since AfterReturningAdviceInterceptor implements the AfterAdvice marker interface, MethodBeforeAdviceInterceptor should implements BeforeAdvice correspondingly.

Backported to: 4.3.19
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Addressed along with minor polishing in all advice interceptor implementations.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.8 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: task A general task
Projects
None yet
Milestone
5.0.8
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues