Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnected client exception logging should differentiate remote service exceptions too [SPR-17341] #21875

Closed
spring-projects-issues opened this issue Oct 4, 2018 · 2 comments
Assignees

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 4, 2018

Rossen Stoyanchev opened SPR-17341 and commented

Currently HttpWebHandlerAdapter suppresses logging of unhandled exceptions from writing to the response that are associated with a client going away. This is useful with streaming responses and was introduced in #18523. However as is clear from #21790 similar exceptions may also occur during request handling while making calls to a remote service, and arguably logging for those should not be suppressed.

This ticket is to explore the possibility of differentiating between the two and suppressing logging only of the former, but not of the latter kind. One option may be to wrap exceptions from ServerHttpResponse#writeWith with something like the Reactor Netty AbortedException and use that to differentiate between server response writing and other socket exception.


Affects: 5.0.9

Issue Links:

  • #21790 o.s.h.s.r.ReactorHttpHandlerAdapter is polluting the logs
  • #18523 WebFlux SSE controller does not detect disconnected client
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 5, 2018

Rossen Stoyanchev commented

Related issue reactor-netty#508.

@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Mar 21, 2019

It looks like Reactor Netty differentiates server and client exceptions with AbortedException vs PrematureCloseException so we don't need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants