Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce use of unpooled data buffers for WebFlux on 5.0.x [SPR-17501] #22033

Closed
spring-projects-issues opened this issue Nov 15, 2018 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 15, 2018

Rossen Stoyanchev opened SPR-17501 and commented

Many of the fixes to prevent leaking pooled data buffers (e.g. #21941) cannot be backported to 5.0.x which cannot use the doOnDiscard hook introduced in reactor-core 3.2. The goal for this ticket is to prevent the issue in 5.0.x by using unpooled buffers by default, and by copying and not retaining any buffers received from the Reactor Netty side. 

 


Affects: 5.0.10

Referenced from: commits 18da718

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.11 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants