Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding @Delimiter support to String converters #22808

Open
philwebb opened this issue Apr 17, 2019 · 1 comment
Open

Consider adding @Delimiter support to String converters #22808

philwebb opened this issue Apr 17, 2019 · 1 comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

Spring Boot currently includes a DelimitedStringToArrayConverter and DelimitedStringToCollectionConverter which allows a @Delimiter annotation to be used to control how Strings are converted.

This functionality is quite useful and it might be a good candidate to port to Spring Framework. AFICT we can rework the existing String converters to support it in a back compatible manner.

@rstoyanchev
Copy link
Contributor

We discussed this, and there are a couple of follow-ups needed to help move this forward.

One, is to have another look at all other similar annotations in Boot, some of which may have been added since, and see if this is the only one still to consider.

Two, it would be useful to consider use cases. There is a concrete example in the linked spring-projects/spring-boot#15019 (comment) but I would need to experiment with it. Generally it's not very clear that this is very common in data binding where the Servlet API already breaks each parameter into a Collection of values. A more likely use case could be the use of property placeholders and @Value but we'll need a small POC to see how it works out.

@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 29, 2023
@jhoeller jhoeller added this to the 6.x Backlog milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants