Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlUtils Javadoc refers to deprecated Apache Commons Lang #23122

Closed
pthorson opened this issue Jun 12, 2019 · 1 comment
Closed

HtmlUtils Javadoc refers to deprecated Apache Commons Lang #23122

pthorson opened this issue Jun 12, 2019 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Milestone

Comments

@pthorson
Copy link

Affects: 5.1.x


The javadoc for HtmlUtils refers users to the Apache Commons Lang StringEscapeUtils class

 * <p>For a comprehensive set of String escaping utilities,
 * consider Apache Commons Lang and its StringEscapeUtils class.

But that is now deprecated and moved to commons-text as of 3.6. If this advice still applies, please update the javadoc to refer to the new location for the class.

Alternatively, since commons lang is no longer required, consider using commons-text in Spring rather than maintaining separate string processing methods.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 12, 2019
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 14, 2019
@sbrannen sbrannen self-assigned this Jun 14, 2019
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task labels Jun 14, 2019
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 14, 2019
@sbrannen sbrannen added this to the 5.1.9 milestone Jun 14, 2019
@sbrannen
Copy link
Member

Thanks for bringing this to our attention.

Alternatively, since commons lang is no longer required, consider using commons-text in Spring rather than maintaining separate string processing methods.

As stated in the Javadoc, "We are not using that class here to avoid a runtime dependency on Commons Lang just for HTML escaping." Thus, the same rationale holds true for Commons Text.

But that is now deprecated and moved to commons-text as of 3.6. If this advice still applies, please update the javadoc to refer to the new location for the class.

I will update the Javadoc accordingly.

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

3 participants