Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - possibly wrong example #25347

Closed
maksimkoniukhau opened this issue Jun 30, 2020 · 3 comments
Closed

Documentation - possibly wrong example #25347

maksimkoniukhau opened this issue Jun 30, 2020 · 3 comments
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation task

Comments

@maksimkoniukhau
Copy link
Contributor

https://docs.spring.io/spring/docs/5.2.7.RELEASE/spring-framework-reference/core.html#aop-schema-params

There is code example in this chapter of documentation

public interface PersonService {

    Person getPerson(String personName, int age);
}

public class DefaultFooService implements FooService {

    public Person getPerson(String name, int age) {
        return new Person(name, age);
    }
}

Maybe you mean

public class DefaultPersonService implements PersonService {}

instead

public class DefaultFooService implements FooService {}

Because further in the example XML configuration is written

<bean id="personService" class="x.y.service.DefaultPersonService"/>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 30, 2020
@quaff
Copy link
Contributor

quaff commented Jul 1, 2020

You should submit a PR.

@maksimkoniukhau
Copy link
Contributor Author

Yes. I did it

@sbrannen
Copy link
Member

sbrannen commented Jul 1, 2020

Superseded by #25351

@sbrannen sbrannen closed this as completed Jul 1, 2020
@sbrannen sbrannen added type: documentation A documentation task status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants