Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently replace String encoding names with StandardCharset arguments #27664

Closed
jhoeller opened this issue Nov 10, 2021 · 4 comments
Closed

Consistently replace String encoding names with StandardCharset arguments #27664

jhoeller opened this issue Nov 10, 2021 · 4 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.0.0-M1

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Nov 10, 2021 •
edited

On a related note to gh-27646, our EncodedResource should consistently be used with StandardCharsets arguments instead of String encoding names. Also, there are URLEncoder/URLDecoder variants with a Charset argument in JDK 10+ now.
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 10, 2021
@jhoeller jhoeller added this to the 6.0 M1 milestone Nov 10, 2021
@jhoeller jhoeller self-assigned this Nov 10, 2021
@dreis2211
Copy link
Contributor

Please check #27554

@jhoeller jhoeller mentioned this issue Nov 10, 2021
Merged
@jhoeller jhoeller changed the title Replace String encoding names with StandardCharset arguments (against JDK 10+ API) Consistently replace String encoding names with StandardCharset arguments Nov 10, 2021
@jhoeller
Copy link
Contributor Author

jhoeller commented Nov 10, 2021 •
edited

Oops, sorry for not noticing your PR before, @dreis2211 ... This consistency commit of mine only really covered a single URLEncoder case but the PR #27646 included some URLDecoder changes as well, next to the toString stuff.

If you could rebase #27554 against current main, we'll see how much we're still missing. From a quick glance, there are quite a few hard-coded "UTF-8" constants in use against URLDecoder still. It'd be great to apply your PR for that purpose!

@dreis2211
Copy link
Contributor

@jhoeller Done

@jhoeller
Copy link
Contributor Author

@dreis2211 Wow that was quick, thanks for the immediate turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M1
Development

No branches or pull requests
2 participants
@jhoeller @dreis2211