Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with equals(…)/hashCode() for ResolvableType.forRawClass(…) #28608

Closed
odrotbohm opened this issue Jun 10, 2022 · 0 comments
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@odrotbohm
Copy link
Member

ResolvableType.forRawClass(…) returns an anonymous subclass of ResolvableType that alters its behavior but does not override equals(…)/hashCode() so that instances created through that method are considered the same as ones created via forClass(…) despite different behavior when trying to resolve generics. This fundamentally breaks the ability to use ResolvableType instances that are potentially created in both ways as map or cache keys.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 10, 2022
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jun 12, 2022
@sbrannen sbrannen added this to the Triage Queue milestone Jun 12, 2022
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 14, 2022
@jhoeller jhoeller self-assigned this Jun 14, 2022
@jhoeller jhoeller modified the milestones: Triage Queue, 6.0.x Jun 14, 2022
@jhoeller jhoeller modified the milestones: 6.0.x, 6.1.x Feb 14, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.1.0-M2 Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants