Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerHttpObservationFilter should not overwrite response status #29353

Closed
bclozel opened this issue Oct 19, 2022 · 0 comments
Closed

ServerHttpObservationFilter should not overwrite response status #29353

bclozel opened this issue Oct 19, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.0.0-RC2

Comments

@bclozel
Copy link
Member

bclozel commented Oct 19, 2022

While the ServerHttpObservationFilter should use the exception thrown for the recorded observation, it should not update the response status as this is likely to be done by the Framework infrastructure or application code.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing labels Oct 19, 2022
@bclozel bclozel added this to the 6.0.0-RC2 milestone Oct 19, 2022
@bclozel bclozel self-assigned this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC2
Development

No branches or pull requests
1 participant
@bclozel