Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javadoc to take virtual threads into account #30905

Closed
wilkinsona opened this issue Jul 17, 2023 · 0 comments
Closed

Update javadoc to take virtual threads into account #30905

wilkinsona opened this issue Jul 17, 2023 · 0 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@wilkinsona
Copy link
Member

Affects: 6.1.0.M2

Similar to the logging changes tracked by #30902, there are some places where the javadoc should also be updated to take virtual threads into account, including:

* <p>By default only a {@link SimpleAsyncTaskExecutor} is used. However when
* using the above two use cases, it's recommended to configure an executor
* backed by a thread pool such as {@link ThreadPoolTaskExecutor}.

and perhaps

* <p>By default a {@link SimpleAsyncTaskExecutor} instance is used.
* It's recommended to change that default in production as the simple executor
* does not re-use threads.

These are just two places that I noticed and I haven't done an exhaustive search so there may be others.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 17, 2023
@jhoeller jhoeller self-assigned this Jul 17, 2023
@jhoeller jhoeller added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 17, 2023
@jhoeller jhoeller added this to the 6.1.0-M3 milestone Jul 17, 2023
@jhoeller jhoeller assigned rstoyanchev and unassigned jhoeller Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants