Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate JOptCommandLinePropertySource #31207

Closed
drothmaler opened this issue Sep 12, 2023 · 2 comments
Closed

Deprecate JOptCommandLinePropertySource #31207

drothmaler opened this issue Sep 12, 2023 · 2 comments
Assignees
@sbrannen
Labels
type: enhancement A general enhancement
Milestone
6.1.0-M5

Comments

@drothmaler
Copy link

drothmaler commented Sep 12, 2023 •
edited by sbrannen

Affects: 6.x

Unfortunately JOpt Simple seems to be dead:

(IMHO) All this does make it a bad option as a reference implementation for an advanced CommandLinePropertySource. It would be better to replace it with something actively maintained library. Some candidates might be:
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 12, 2023
@snicoll
Copy link
Member

snicoll commented Sep 13, 2023 •
edited by sbrannen

Thanks for the report.

We've decided to deprecate our support for JOptCommandLinePropertySource and do not consider a replacement at this time.

@snicoll snicoll changed the title Deprecate/Remove/Replace JOptCommandLinePropertySource Deprecate JOptCommandLinePropertySource Sep 13, 2023
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 13, 2023
@snicoll snicoll added this to the 6.1.0-M5 milestone Sep 13, 2023
@snicoll snicoll self-assigned this Sep 13, 2023
@sbrannen sbrannen changed the title Deprecate JOptCommandLinePropertySource Deprecate CommandLinePropertySource and associated implementations Sep 13, 2023
@sbrannen sbrannen assigned sbrannen and unassigned snicoll Sep 13, 2023
@sbrannen
Copy link
Member

sbrannen commented Sep 13, 2023 •
edited

Reopening to revert the deprecation of CommandLinePropertySource and SimpleCommandLinePropertySource, since we have discovered that Spring Boot actively uses SimpleCommandLinePropertySource in org.springframework.boot.SpringApplication.

@sbrannen sbrannen reopened this Sep 13, 2023
@sbrannen sbrannen changed the title Deprecate CommandLinePropertySource and associated implementations Deprecate JOptCommandLinePropertySource Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M5
Development

No branches or pull requests
4 participants
@sbrannen @drothmaler @snicoll @spring-projects-issues