Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not count exchanges outcomes as UNKNOWN if response was committed #31387

Closed
bclozel opened this issue Oct 9, 2023 · 1 comment
Closed

Do not count exchanges outcomes as UNKNOWN if response was committed #31387

bclozel opened this issue Oct 9, 2023 · 1 comment
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another theme: observability An issue related to observability and tracing type: enhancement A general enhancement

Comments

@bclozel
Copy link
Member

bclozel commented Oct 9, 2023

Per this comment, we should not mark observed HTTP server exchanges as "UNKNOWN" outcomes if the response was committed. Chances are very high that the response was sent but that the client closed the connection aggressively before we had a chance to complete the exchange properly.

We should instead only count UNKNOWN outcomes if the client disconnected and the response was not committed.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement theme: observability An issue related to observability and tracing labels Oct 9, 2023
@bclozel bclozel added this to the 6.1.0-RC1 milestone Oct 9, 2023
@bclozel bclozel self-assigned this Oct 9, 2023
@bclozel bclozel mentioned this issue Oct 9, 2023
Closed
@bclozel bclozel modified the milestones: 6.1.0-RC1, 6.1.0-RC2 Oct 11, 2023
@bclozel bclozel added the status: superseded An issue that has been superseded by another label Oct 12, 2023
@bclozel
Copy link
Member Author

bclozel commented Oct 12, 2023

Superseded by #31417 - we don't need this type of refinement when the root cause is probably going to be addressed directly in the instrumentation.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bclozel