Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCompiler should allow to configure the Locale that renders compiler messages #31408

Closed
snicoll opened this issue Oct 11, 2023 · 1 comment
Closed

TestCompiler should allow to configure the Locale that renders compiler messages #31408

snicoll opened this issue Oct 11, 2023 · 1 comment
Assignees
@snicoll
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.1.0-RC1

Comments

@snicoll
Copy link
Member

snicoll commented Oct 11, 2023

As discovered by #31407, we can't reliably test messages from the compiler as they are rendered by the default locale at the moment. We should offer a way to set that to a specific one.
@snicoll snicoll added the type: enhancement A general enhancement label Oct 11, 2023
@snicoll snicoll added this to the 6.1.0-RC1 milestone Oct 11, 2023
@snicoll snicoll self-assigned this Oct 11, 2023
@snicoll snicoll mentioned this issue Oct 11, 2023
Closed
@snicoll snicoll mentioned this issue Nov 1, 2023
Closed
@snicoll
Copy link
Member Author

snicoll commented Nov 1, 2023

FTR this enhancement was reverted in #31536

@jhoeller jhoeller added the in: test Issues in the test module label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

No branches or pull requests
2 participants
@snicoll @jhoeller