Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestTemplate initialization documentation in 6.0.x mentions Netty, yet no ClientHttpRequestFactory is present in the package. #31526

Closed
gheyle opened this issue Oct 31, 2023 · 1 comment
Closed

RestTemplate initialization documentation in 6.0.x mentions Netty, yet no ClientHttpRequestFactory is present in the package. #31526

gheyle opened this issue Oct 31, 2023 · 1 comment
Assignees
@rstoyanchev
Labels
type: documentation A documentation task
Milestone
6.0.14

Comments

@gheyle
Copy link

gheyle commented Oct 31, 2023

Affects: 6.0.x

In the documentation of rest-clients.adoc it mentions that Netty is an option. Yet I only see this in the 6.1.x branch: 20dd66c of the org.springframework.http.client package. Also the Spring Boot v3.1.5 documentation does not mention Netty as an option for RestTemplate: rest-client.adoc.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 31, 2023
@rstoyanchev
Copy link
Contributor

This is related to the old Netty4ClientHttpRequest based on AsynHttpRequestFactory, deprecated in 5.0 and removed in 6.0. It seems this wasn't removed from the documentation. It has been there since 2018 with d007c25.

@rstoyanchev rstoyanchev self-assigned this Oct 31, 2023
@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 31, 2023
@rstoyanchev rstoyanchev added this to the 6.0.14 milestone Oct 31, 2023
@rstoyanchev rstoyanchev changed the title RestTemplate initialization documentation mentions Netty, yet no ClientHttpRequestFactory is present in the package. RestTemplate initialization documentation in 6.0.x mentions Netty, yet no ClientHttpRequestFactory is present in the package. Oct 31, 2023
@snicoll snicoll added type: documentation A documentation task and removed type: task A general task labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: documentation A documentation task
Projects
None yet
Milestone
6.0.14
Development

No branches or pull requests
4 participants
@rstoyanchev @snicoll @spring-projects-issues @gheyle