Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextDataFetcherDecorator removes TrivialDataFetcher hint #980

Closed
osi opened this issue May 21, 2024 · 1 comment
Closed

ContextDataFetcherDecorator removes TrivialDataFetcher hint #980

osi opened this issue May 21, 2024 · 1 comment
Labels
in: core Issues related to config and core support status: superseded Issue is superseded by another

Comments

@osi
Copy link
Contributor

osi commented May 21, 2024

when the ContextDataFetcherDecorator runs to decorate all defined data fetchers in the code registry, it stomps over the TrivialDataFetcher marker.

it should either:

  • preserve the marker, so the data fetchers do not get instrumentation applied
  • have a policy of not decorating trivial data fetchers (preserving them as-is)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 21, 2024
@bclozel bclozel added type: bug A general bug in: core Issues related to config and core support for: backport-to-1.2.x Marks an issue as a candidate for backport to 1.2.x and removed status: waiting-for-triage An issue we've not yet triaged labels May 22, 2024
@bclozel bclozel added this to the 1.3.1 milestone May 22, 2024
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-1.2.x Marks an issue as a candidate for backport to 1.2.x labels May 22, 2024
@github-actions github-actions bot mentioned this issue May 22, 2024
Closed
@rstoyanchev rstoyanchev linked a pull request May 24, 2024 that will close this issue
Do not apply ContextDataFetcherDecorator to TrivialDataFetcher instances #983
Closed
@rstoyanchev
Copy link
Contributor

Superseded by #983.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
@rstoyanchev rstoyanchev removed this from the 1.3.1 milestone May 24, 2024
@rstoyanchev rstoyanchev added status: superseded Issue is superseded by another and removed type: bug A general bug status: backported An issue that has been backported to maintenance branches labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues related to config and core support status: superseded Issue is superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not apply ContextDataFetcherDecorator to TrivialDataFetcher instances osi/spring-graphql
4 participants
@osi @bclozel @rstoyanchev @spring-projects-issues